-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle unimplemented file capabilities slightly more gracefully #1089
fix: handle unimplemented file capabilities slightly more gracefully #1089
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is actually possible. The workspace provides a method for that |
Ah, then I will rework this to do that. |
It looks like the |
58f3207
to
8de67e0
Compare
48a9366
to
77476c8
Compare
Now that the other PRs in biome are merged, everything should be good to go here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would use the message "Not supported"
instead. The word "available" doesn't fit the case, I think. I would address @Princesseuh 's comment
77476c8
to
bae0f9b
Compare
Summary
The HTML language currently doesn't implement some of the file capabilities that the playground expects. This makes it so that a language does not need to implement some of these capabilities in order to work in the playground, requiring less code changes.
Ideally though, we would grab the file capabilities from biome instead of try/catching.(This has been reworked to do so.)This doesn't make HTML fully functional in the playground -- other things in biome needs to be implemented first.Once this is merged, HTML will be fully functional in the playground (for the features that are implemented)