-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release vs code extension v3 #974
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
20aacf8
to
4d9f049
Compare
ec736d5
to
46b8c5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good! Generally, I think that each option should have a tiny example that shows how to write it, so people can quickly copy it.
To define projects in a **workspace**, add a `settings.biome.projects` property to the `.code-workspace` file. This setting accepts an | ||
array of project definitions, each of which has the following properties: | ||
|
||
- `name`: The **name of the workspace folder** that the project is associated with | ||
- `path` : The **path to the project directory**, _relative to the root of the workspace folder_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, it would be nice to show a JSONC
example that people can visually see and maybe copy. The example will be helpful to clarify way more the path
. Also, it isn't clear if both properties are optional or mandatory
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
What's the status for this one? It says in the related PR that this is shipped, so is it only the docs that are missing? I've tried adding this to "biome.projects": [
{
"path": "client/",
}
] (based on these fixtures: https://github.com/biomejs/biome-vscode/blob/097735e24085b2cd036ba1bb86f059915c561976/test/fixtures/single-root-workspace-monorepo/.vscode/settings.json) |
Only applies to the pre release extension |
@nhedger Alright, many thanks! 🙏🏻 I tried out the pre-release extension and still couldn't get this to work. I got it to pickup the projects, but I couldn't configure the binary (probably the same as mentioned in this comment at the bottom biomejs/biome#4666 (comment)). Anyway, used a symlink from repo root for now as a workaround. Will try again after the next extension release! |
Summary
This PR updates the VS Code reference for the v3 release.