Codontable bugs. #386
Closed
Codontable bugs. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not return empty value but simple quotes
carandraug
pushed a commit
that referenced
this pull request
Apr 26, 2024
carandraug
pushed a commit
that referenced
this pull request
Apr 26, 2024
Without this extra check, negative table IDs were being counted from the end of the tables array.
carandraug
added a commit
that referenced
this pull request
Apr 26, 2024
Codon tables are sometimes removed, e.g., codon table id=7. Previously, instead of being handled as invalid tables, these would return the "''" (because they were parsed from a `qw()`. Since a73febe the tables are parsed straight from the gc.prt, the tables array gets a real empty string, adn are handled as invalid. In PR #386 a test was added that the "''" was returned. This is no longer needed. This commit tests that when a table is empty (id=7) it's properly identified as invalid to avoid a regression.
|
Thank you for report and patches. I've edited them and merged. One of the changes (testing that removed tables such as id=7 was the string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs in codon table:
Bio::Tools::CodonTable->new( -id => 0);but was working only by creating a codon table by default and using theidfunction to set the table to 0