Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pydantic models for health report #1057

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix Pydantic models for health report #1057

merged 5 commits into from
Mar 19, 2024

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Mar 19, 2024

This PR fixes an issue where old runs in the Bioregistry health report didn't validate against the current pydantic model. I wrote a script that calculated the missing data and also made "delta" optional since the first item on the list will never have a delta. It also re-runs the health report

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 40.43%. Comparing base (7095608) to head (a09bbd1).
Report is 3 commits behind head on main.

Files Patch % Lines
src/bioregistry/health/check_providers.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   40.43%   40.43%           
=======================================
  Files         149      149           
  Lines        8273     8273           
  Branches     1916     1916           
=======================================
  Hits         3345     3345           
  Misses       4719     4719           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt cthoyt marked this pull request as ready for review March 19, 2024 11:53
@cthoyt cthoyt merged commit 52b6ccd into main Mar 19, 2024
12 of 13 checks passed
@cthoyt cthoyt deleted the fix-health branch March 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant