Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CURIE and URI handling #791

Merged
merged 11 commits into from
Apr 3, 2023
Merged

Improve CURIE and URI handling #791

merged 11 commits into from
Apr 3, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Apr 3, 2023

This PR does the following:

  1. Finally removes the prefix_map option from parsing URIs/IRIs and bumps by a minor version. Also removes some related code in the public API that was used to support this functionality, including the ensure_prefix_list() function. This probably wasn't used by anyone.
  2. Consolidates implementation of IRI parsing into the Manager class
  3. Enables use_preferred on the relevant functions as suggested in Broader support for use_preferred in CURIE/prefix normalization #790
  4. Updates deprecated testing

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.17 🎉

Comparison is base (96c63b3) 39.78% compared to head (8db704a) 39.95%.

❗ Current head 8db704a differs from pull request most recent head e46f4ed. Consider uploading reports for the commit e46f4ed to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   39.78%   39.95%   +0.17%     
==========================================
  Files         132      132              
  Lines        7530     7490      -40     
  Branches     1741     1730      -11     
==========================================
- Hits         2996     2993       -3     
+ Misses       4354     4312      -42     
- Partials      180      185       +5     
Impacted Files Coverage Δ
src/bioregistry/resource_manager.py 73.78% <51.51%> (+0.23%) ⬆️
src/bioregistry/parse_iri.py 66.66% <54.54%> (+33.33%) ⬆️
src/bioregistry/resolve.py 55.31% <62.50%> (-0.43%) ⬇️
src/bioregistry/__init__.py 100.00% <100.00%> (ø)
src/bioregistry/constants.py 100.00% <100.00%> (ø)
src/bioregistry/version.py 68.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cthoyt cthoyt marked this pull request as ready for review April 3, 2023 13:35
@cthoyt cthoyt merged commit df5030e into main Apr 3, 2023
@cthoyt cthoyt deleted the update-parsing branch April 3, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants