Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for annotating unresolvable ontologies, update OLS processing, and better annotate HPATH #993

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 22, 2023

Closes #927

This PR does the following:

  • Adds a new boolean field uri_format_resolvable so we can explicitly annotate when URI format strings are known to not be resolvable
  • Adds a note on to the page for a resource when this flag is set to true
  • Updates OLS download processing to more carefully annotate if the download is OWL, OBO, RDF, or other

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d0292d2) 40.93% compared to head (3861523) 40.89%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/bioregistry/external/ols.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   40.93%   40.89%   -0.05%     
==========================================
  Files         138      138              
  Lines        7905     7916      +11     
  Branches     1841     1845       +4     
==========================================
+ Hits         3236     3237       +1     
- Misses       4467     4477      +10     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt cthoyt merged commit 1b801b9 into main Nov 22, 2023
11 of 13 checks passed
@cthoyt cthoyt deleted the add-mc-resolvable-note branch November 22, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The url that resolves the hpath ontology
1 participant