Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure build-time dependencies #4755

Closed

Conversation

covracer
Copy link

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

Closes astral-sh/uv#4069 (comment)

https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use describes this style of configuring build-time dependencies (requirements). As of 2024-06-24, uv pip install . (uv 0.1.41) and pip install --use-pep517 . (pip 24.1) will fail without this file.

Flags which can work around the issue for prior biopython versions are --legacy-setup-py (uv only) and --no-build-isolation (pip and uv).

Test installation with the --use-pep517 flag and add a pre-commit hook to validate pyproject.toml.

@peterjc
Copy link
Member

peterjc commented Jun 25, 2024

This is I think related to #4749 which takes a simpler approach and might also solve astral-sh/uv#4069 (comment)

@peterjc
Copy link
Member

peterjc commented Jun 25, 2024

@peterjc
Copy link
Member

peterjc commented Jun 25, 2024

The test_WellRecord failure on CircleCI has been fixed on the default, see #4754

@covracer
Copy link
Author

This is I think related to #4749 which takes a simpler approach and might also solve astral-sh/uv#4069 (comment)

Thanks! I've tested that approach and it does fix the issue. Closing this PR in favor of #4749.

@covracer covracer closed this Jun 25, 2024
@peterjc
Copy link
Member

peterjc commented Jun 26, 2024

OK, at some point we'll probably have to update the setup/build system, but it wasn't something I wanted to do now when I'm chasing bugs blocking the release. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: invalid command 'bdist_wheel'
2 participants