-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send MetaKG to threads #21
Conversation
@rjawesome Please re-review related PRs and fix with new merge conflicts -- I'll review and merge once you have. |
It may be helpful to link this/related PRs to the issue that they address? |
@colleenXu Implementation covers performance improvements not currently in an issue, as well as addressing biothings/biothings_explorer#703 |
All Associated PRs should be fixed |
@rjawesome Just about ready to merge, the only thing I'm a bit confused about is the new data/kg.json file. It doesn't appear to be used in related PRs? Am I mistaken, or should it be removed? |
You are correct about kg/data.json (it's removed). I also changed it so the specs would be passed through the thread (similar to MetaKG) instead of through redis. |
This creates a MetaKG during the cron job and saves the operations. It then sends the operations to each thread. This allows the time to create MetaKG to go from around 500ms to 1ms.
This also writes smartapi specs to redis, so they can be used in query graph handler for finding unregistered APIs (prevents read-write conflicts).