Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly merge semmedb sentences #219

Merged
merged 7 commits into from
Oct 20, 2024
Merged

properly merge semmedb sentences #219

merged 7 commits into from
Oct 20, 2024

Conversation

rjawesome
Copy link
Contributor

@colleenXu
Copy link
Contributor

colleenXu commented Oct 4, 2024

@rjawesome

I tested this and Examples 1 and 2 now have 51 text-snippet edge attributes, rather than capping at 50. So....maybe that needs adjusting?

Also remember the additional ask in biothings/biothings_explorer#833 (comment)

@colleenXu
Copy link
Contributor

colleenXu commented Oct 18, 2024

@rjawesome @tokebe

Small thing, can it be done ASAP?
It looks like the evidence_count is being generated after truncating to 50 PMIDs, because both examples's evidence_count is exactly 50. If this is the case, is it possible to change this behavior so the evidence_count is the PMID count BEFORE truncation? I guess it's not a big deal, but it's an indicator to us that truncation is happening.

Otherwise it looks good: the off-by-1 problem is fixed.

(based on latest commits, described here)

@rjawesome
Copy link
Contributor Author

@colleenXu the evidence count is fixed so it is counted before truncation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants