Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Conform variable names to standardized vocabulary (pass#1) #47

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

tokebe
Copy link
Member

@tokebe tokebe commented Mar 4, 2022

This PR is a first-pass attempt to address biothings/biothings_explorer/issues/379.

No actual behavior has been changed. Variable names have been changed to better reflect a set of standardized vocabulary for internal data structures (which should better reflect their purpose and relationship to external data structures).

Due to some data structures passed between modules, this PR requires biothings/bte_trapi_query_graph_handler/pull/93.

This PR will require additional review and discussion to ensure that there are no additional changes that should be made, etc.

@tokebe tokebe requested review from ariutta and colleenXu March 4, 2022 18:55
Copy link
Contributor

@ariutta ariutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@colleenXu
Copy link
Contributor

I don't see issues on this. I think the main discussion is in the other PR...

@colleenXu
Copy link
Contributor

colleenXu commented Mar 14, 2022

@tokebe I'm seeing one automated test that needs updating. The screenshot may be clearer

Screen Shot 2022-03-13 at 9 52 42 PM

FAIL test/query.test.js
● Test query class › Test _merge function › logs is correctly populated

expect(received).toHaveProperty(path, value)

Expected path: "message"

Expected value: "call-apis: Total number of results returned for this query is 3"
Received value: "call-apis: Total number of records returned for this query is 3"

  86 |             caller._merge([success1, success2, success1, fail, fail]);
  87 |             expect(caller.logs).toHaveLength(1);
> 88 |             expect(caller.logs[0]).toHaveProperty("message", "call-apis: Total number of results returned for this query is 3")
     |                                    ^
  89 |         })
  90 |     })
  91 |

  at Object.<anonymous> (__test__/query.test.js:88:36)

@tokebe tokebe merged commit 74e8a1f into main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants