feat: don't require ua-parser-js in lambda-context #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: If you want to continue to use `ua-parser-js` in `lambda-context` you will need to use `lambdaContextWithUaParser` and pass in your own parser function as described here: https://github.com/birchill/bugsnag-zero?tab=readme-ov-file#using-a-custom-user-agent-string-parser This is because from version `ua-parser-js` version 2 onwards, users are required to either use the AGPL version or license the library. It's best to allow users of this package to decide how they want to consume `ua-parser-js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: If you want to continue to use
ua-parser-jsinlambda-contextyou will need to uselambdaContextWithUaParserandpass in your own parser function as described here:
https://github.com/birchill/bugsnag-zero?tab=readme-ov-file#using-a-custom-user-agent-string-parser
This is because from version
ua-parser-jsversion 2 onwards, users arerequired to either use the AGPL version or license the library.
It's best to allow users of this package to decide how they want to
consume
ua-parser-js.