Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to install-docker.sh and comment update for other scripts due to Magpie upgrade #207

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

tlvu
Copy link
Collaborator

@tlvu tlvu commented Nov 3, 2021

Found when trying to bring up the new production host for PAVICS.

install-docker.sh: fix to work with users with sudo priviledge. Before it needed user root.

Other comments in scripts are due to new Magpie in PR #107.

tlvu added 5 commits October 24, 2021 22:15
During Vagrant setup, the provisionning step was run as root so that was
fine but when setting up Notos, we are provisionning the new machine as
a regular user with sudo access so the fix was needed.

Error fixed:
```
+ echo 'export PATH="$PATH:/usr/local/bin"'
./birdhouse/vagrant-utils/install-docker.sh: line 93: /etc/profile.d/usr_local_path.sh: Permission denied
```
@tlvu tlvu requested a review from matprov November 3, 2021 14:29
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/761/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-install-scripts
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL :

NOTEBOOK TEST RESULTS
    
</code>

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/762/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-install-scripts
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL :

NOTEBOOK TEST RESULTS
    
</code>

@github-actions github-actions bot added ci/operations Continuous Integration components documentation Improvements or additions to documentation labels Nov 3, 2021
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/764/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-install-scripts
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL :

NOTEBOOK TEST RESULTS
    
</code>

@tlvu tlvu merged commit 08b25ce into master Nov 3, 2021
@tlvu tlvu deleted the fix-install-scripts branch November 3, 2021 21:40
@huard huard mentioned this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/operations Continuous Integration components documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants