-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weaver: bump version to 5.1.1 #439
Conversation
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's a simple PR :D Could you maybe explain very briefly in the changelog what fixes or features we are trying to get with the new Weaver? If too long to summarize, maybe just put the Weaver changelog diff URL between 4.32.0 and 5.1.1.
@fmigneault any idea why the jenkins tests aren't running for this one? It would be useful to double check that none of the weaver tests fail with the update. |
run tests |
@mishaschwartz As a workaround in the meantime, I triggered it manually from Jenkins: http://daccs-jenkins.crim.ca/job/DACCS-iac-birdhouse/2560/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but waiting on what the CI responds for test execution...
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2560/Result ❌ FAILURE BIRDHOUSE_DEPLOY_BRANCH : bump-weaver-5.1.0 DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1562/NOTEBOOK TEST RESULTS |
@mishaschwartz
|
Ok thanks! I've been investigating on my side but I haven't been able to get a consistent result to debug. If you have some time in the near future could you please have a look as well? |
run tests |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2660/Result ❌ FAILURE BIRDHOUSE_DEPLOY_BRANCH : bump-weaver-5.1.0 DACCS_IAC_BRANCH : DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca
|
I looks like the tests may be failing because the test data was never actually downloaded due to a permission denied error.
It seems that the user that runs this stage in the build does not have permission to create directories at the correct location so there is no directory to put the file when it is downloaded with This is just one example, if you look at the log output you can see that this same error occurs for every file downloaded through the Do you mind checking this out? |
Doesn't look like there were any changes related to test data setup since #439 (comment), but that one ran. Not sure of the cause, but will wait to see if it can be replicated. |
Is it possible that running the tests with the "run tests" comment runs with a different user than if the test is triggered by GitHub? |
Yes. There is a specific user for CI triggers. However, it is not that user that is used within the instance doing the operations. This should be the "same" |
## Overview See changes in https://pavics-weaver.readthedocs.io/en/latest/changes.html#changes-5-6-1 Running here: https://hirondelle.crim.ca/weaver/versions Corresponding changes evaluated during OGC initiatives with cross-platform provider interoperability tests. ## Changes **Non-breaking changes** - Weaver: bump version to [5.6.1](https://github.com/crim-ca/weaver/tree/5.6.1). - See full changes details in [Weaver changes](https://pavics-weaver.readthedocs.io/en/latest/changes.html#changes-5-6-1) - In summary: - multiple control setting options to customize some behaviors - improved *OGC API - Processes* standard conformance - improved support of *Common Workflow Language (CWL)* features (secrets, sub-workflow, auth-propagation, etc.) - Weaver: WPS retry logic on post-compose step. - Apply `--network birdhouse_default` to the Docker `curl` image to allow HTTP requests to properly resolve against the running services (WPS bird providers, Weave and Magpie). In some cases, this network would not be automatically resolved. - Fix the index used during HTTP request retry to avoid going one step over the intended retry attempts. **Breaking changes** - n/a ## Related Issue / Discussion - Closes #439 Merge the PR since it has issues running the CI somehow. Replace by this one all together. ## Additional Information ## CI Operations birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false
Overview
See changes in the Weaver changes file
Changes
Non-breaking changes
Breaking changes
Related Issue / Discussion
Additional Information
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false