Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip eggshell #72

Merged
merged 1 commit into from
Dec 18, 2018
Merged

skip eggshell #72

merged 1 commit into from
Dec 18, 2018

Conversation

cehbrecht
Copy link
Member

@cehbrecht cehbrecht commented Dec 18, 2018 •
edited
Loading

Overview

This PR skips the eggshell for now. eggshell is quite fragile ... we can let it grow with flyingpigeon and blackswan.

Emu might be used as wps test service:
bird-house/bird-house.github.io#28

Changes:

  • Skipped eggshell (process OutputFormats)
  • Updated pywps
  • only use packages from conda-forge (skipped birdhouse)

Related Issue / Discussion

Additional Information

@cehbrecht cehbrecht added this to the 0.10.0 milestone Dec 18, 2018
@cehbrecht cehbrecht self-assigned this Dec 18, 2018
huard
huard approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we eventually migrate to using pathlib.Path to paths. It doesn't have to be now, but I find the file handling code to be much more elegant.

@huard huard merged commit ca81836 into master Dec 18, 2018
@cehbrecht cehbrecht deleted the skip-eggshell branch December 18, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

@nilshempelmann nilshempelmann Awaiting requested review from nilshempelmann

Assignees

@cehbrecht cehbrecht

Labels
enhancement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cehbrecht @huard