owsproxy adapter fails

[cehbrecht]

In owsproxy.includeme the adapter code for owsproxy_config gets a config but it does expect a request:

twitcher/twitcher/owsproxy.py

Line 217 in ad623c0

get_adapter_factory(config).owsproxy_config(config)

@fmigneault How is the adapter meant to work here?

When I replace the adapter code with:

def includeme(config):
    # from twitcher.adapter import get_adapter_factory
    # get_adapter_factory(config).owsproxy_config(config)
    owsproxy_defaultconfig(config)

... the owsproxy gets correctly initialized.

[fmigneault]

@cehbrecht
DefaultAdapter.owsproxy_config calls the same thing :

twitcher/twitcher/adapter/default.py

Lines 33 to 36 in 89d8c03

	def owsproxy_config(self, request):
	from twitcher.owsproxy import owsproxy_defaultconfig
	config = self.configurator_factory(request)
	owsproxy_defaultconfig(config)

twitcher/twitcher/adapter/default.py

Lines 18 to 20 in 89d8c03

	def configurator_factory(self, request):
	settings = get_settings(request)
	return Configurator(settings=settings)

The get_settings method allows as input any of pyramid's Configurator, Registry, Request or literal settings dictionary. So the config is resolved to settings in any case. The input name could be updated to reflect a more appropriate behaviour in this specific case.

Probably some configs are lost when creating the 'new' Configurator from settings.

[cehbrecht]

fixed by PR #73.