Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ws library #12

Open
birgitta410 opened this issue Jul 30, 2017 · 0 comments
Open

Upgrade ws library #12

birgitta410 opened this issue Jul 30, 2017 · 0 comments

Comments

@birgitta410
Copy link
Owner

The ws library is quite out of date, at the time of opening this issue, the latest version is 3.1.0.

Found some breaking changes:

ws.upgradeReq is gone,

wss.on('connection', function(ws) {
    console.log('connecting to /' + ws.upgradeReq.url); // will fail
    ...
});

instead:

wss.on('connection', function(ws, req) {
    wsUrl = req.url;
    console.log('connecting to ' + wsUrl);
    ...      
});

Secondly, the way this implements paths for websocket servers is not supported anymore:
websockets/ws#885
Changing this is a bit more tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant