Support for ECDSA signatures on curve secp256r1 #165
Merged
+205
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geal
changed the title
tarcieri
reviewed
May 20, 2024
Geal
commented
May 22, 2024
Geal
commented
May 23, 2024
|
|
|
ok, I think this is in a good shape now. The ref implementation is ready, and it is much simpler now wit the refactorings due to the payoad changes |
divarvel
approved these changes
Nov 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #79
To allow Biscuit tokens to be signed by HSM or other key managers, we introduce a way to use ECDSA to sign blocks
TODO: