Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature payload format v1 #175

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Signature payload format v1 #175

merged 15 commits into from
Nov 19, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Nov 11, 2024

No description provided.

@Geal Geal changed the base branch from main to dev November 11, 2024 13:27
SPECIFICATIONS.md Outdated Show resolved Hide resolved
schema.proto Outdated Show resolved Hide resolved
Geal and others added 3 commits November 15, 2024 19:31
Co-authored-by: Clément Delafargue <clement.delafargue@outscale.com>
@Geal
Copy link
Contributor Author

Geal commented Nov 17, 2024

updated with the lastest changes from a1a2d59. This should work well now. There's one last decision here: do we update the sealing signature payload or remove sealing entirely?

@divarvel
Copy link
Collaborator

This looks really good.

A couple suggestions:

  • separate the authority block signature description from subsequent blocks, this will prevent invalid combinations such as having an external signature defined, but no previous signature (this does not change anything to the actual behaviour, it just makes the spec clearer). This would also help describing how to sign attenuation blocks as block n+1, with n >= 0, instead of having a single description for block n with n >= 0 with references to n-1 (which is not defined for n = 0)
  • reorder signature elements to put the optional elements at the end
  • prefix the external signature input with \0EXTERNAL\0 to avoid having the same input for the regular and external signatures

SPECIFICATIONS.md Outdated Show resolved Hide resolved
SPECIFICATIONS.md Outdated Show resolved Hide resolved
SPECIFICATIONS.md Outdated Show resolved Hide resolved
SPECIFICATIONS.md Outdated Show resolved Hide resolved
SPECIFICATIONS.md Outdated Show resolved Hide resolved
SPECIFICATIONS.md Outdated Show resolved Hide resolved
Geal and others added 3 commits November 19, 2024 11:06
before the external signature,to group the optional parts at the end
Co-authored-by: Clément Delafargue <clement.delafargue@outscale.com>
@Geal Geal marked this pull request as ready for review November 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants