-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature payload format v1 #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divarvel
reviewed
Nov 12, 2024
Co-authored-by: Clément Delafargue <clement.delafargue@outscale.com>
updated with the lastest changes from a1a2d59. This should work well now. There's one last decision here: do we update the sealing signature payload or remove sealing entirely? |
This looks really good. A couple suggestions:
|
divarvel
reviewed
Nov 19, 2024
Co-authored-by: Clément Delafargue <clement.delafargue@outscale.com>
divarvel
reviewed
Nov 19, 2024
before the external signature,to group the optional parts at the end
Co-authored-by: Clément Delafargue <clement.delafargue@outscale.com>
divarvel
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.