Adding Temperature 🌡️ to Inspectors 🧐 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhnyel
changed the title
deven96
reviewed
Dec 7, 2022
inspector/inspector.go
Outdated
| @@ -29,6 +29,7 @@ var inspectorMap = map[string]NewInspector{ | |||
| `process`: NewProcess, | |||
| `loadavg`: NewLoadAvg, | |||
| `tcp`: NewTcp, | |||
| `temperature`: NewTemp, | |||
There was a problem hiding this comment.
In the spirit of short forms temperature seems too long... maybe just temp
inspector/temp.go
Outdated
| return nil, errors.New("Cannot use 'temp' command on drivers outside (linux, darwin, windows)") | ||
| } | ||
|
|
||
| // $ cat /sys/class/thermal/thermal_zone*/temp |
There was a problem hiding this comment.
Move this to the Parse method of the platform specific inspector
inspector/temp.go
Outdated
| output = strings.ReplaceAll(output, " ", "") | ||
| value, err := strconv.ParseFloat(output, 64) | ||
| if err != nil { | ||
| log.Fatalf(`Error Parsing Temperature: %s `, err) |
There was a problem hiding this comment.
Let's try not to fatally kill everybody.... just turn this to an Errorf on parsing issues
There was a problem hiding this comment.
Same for other Fatals ... whenever the function can't return an error, just use Errorf but if it can return an error then return it
derhnyel
force-pushed
the
feature/test-goreleaser
branch
4 times, most recently
from
fd70e50
to
5be290b
Compare
derhnyel
force-pushed
the
feature/test-goreleaser
branch
from
5be290b
to
ba321ba
Compare
|
Closing as inconsistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves #23
TODO