Implement requested changes in PR #4097

Change member name OptionParser cmdParser -> parser.
Change server listening port to 9998, client port to 9998.
Change constructor argument from String[] param -> args.
Print the result only, w/out exec time.
Print help to stdout, not stderr.
Use explicit system SUCCESS/FAIL codes in System.exit(0 || 1).

cli/src/main/java/bisq/cli/app/BisqCliMain.java

@@ -33,7 +33,6 @@
 import static bisq.cli.app.CommandParser.GETVERSION;
 import static bisq.cli.app.CommandParser.STOPSERVER;
 import static java.lang.String.format;
-import static java.lang.System.currentTimeMillis;
 import static java.lang.System.exit;
 import static java.lang.System.out;
 
@@ -43,27 +42,23 @@
 @Slf4j
 public class BisqCliMain {
 
+    private static final int EXIT_SUCCESS = 0;
+    private static final int EXIT_FAILURE = 1;
+
     private final ManagedChannel channel;
     private final CliCommand cmd;
-    private final OptionParser cmdParser;
+    private final OptionParser parser;
 
     public static void main(String[] args) {
-        new BisqCliMain("localhost", 8888, args);
+        new BisqCliMain("localhost", 9998, args);
     }
 
-    private BisqCliMain(String host, int port, String[] params) {
+    private BisqCliMain(String host, int port, String[] args) {
         // Channels are secure by default (via SSL/TLS);  for the example disable TLS to avoid needing certificates.
         this(ManagedChannelBuilder.forAddress(host, port).usePlaintext().build());
-
-        long startTs = currentTimeMillis();
-
-        String command = parseCommand(params);
+        String command = parseCommand(args);
         String result = runCommand(command);
-
-        // First response is rather slow (300 ms) but following responses are fast (3-5 ms).
-        // log.info("{}\t{}", result, cmd.responseTime.apply(startTs));
-        out.println(result + "\t" + cmd.responseTime.apply(startTs));
-
+        out.println(result);
         try {
             shutdown(); // Orderly channel shutdown
         } catch (InterruptedException ignored) {
@@ -76,7 +71,7 @@ private BisqCliMain(String host, int port, String[] params) {
     private BisqCliMain(ManagedChannel channel) {
         this.channel = channel;
         this.cmd = new CliCommand(channel);
-        this.cmdParser = new CommandParser().configure();
+        this.parser = new CommandParser().configure();
     }
 
     private String runCommand(String command) {
@@ -100,18 +95,18 @@ private String runCommand(String command) {
     }
 
     private String parseCommand(String[] params) {
-        OptionSpec<String> nonOptions = cmdParser.nonOptions().ofType(String.class);
-        OptionSet options = cmdParser.parse(params);
+        OptionSpec<String> nonOptions = parser.nonOptions().ofType(String.class);
+        OptionSet options = parser.parse(params);
         List<String> detectedOptions = nonOptions.values(options);
         if (detectedOptions.isEmpty()) {
             CommandParser.printUsage();
-            exit(0);
+            exit(EXIT_FAILURE);
         }
         return detectedOptions.get(0);
     }
 
     private void shutdown() throws InterruptedException {
         channel.shutdown().awaitTermination(1, TimeUnit.SECONDS);
-        exit(0);
+        exit(EXIT_SUCCESS);
     }
 }

cli/src/main/java/bisq/cli/app/CliCommand.java

@@ -18,8 +18,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-import static java.lang.System.currentTimeMillis;
-
 @Slf4j
 final class CliCommand {
 
@@ -32,8 +30,6 @@ final class CliCommand {
     @SuppressWarnings("BigDecimalMethodWithoutRoundingCalled")
     final Function<Long, String> prettyBalance = (sats) -> btcFormat.format(BigDecimal.valueOf(sats).divide(satoshiDivisor));
 
-    final Function<Long, String> responseTime = (t0) -> "(response time:  " + (currentTimeMillis() - t0) + " ms)";
-
     CliCommand(ManagedChannel channel) {
         getBalanceStub = GetBalanceGrpc.newBlockingStub(channel);
         getVersionStub = GetVersionGrpc.newBlockingStub(channel);

cli/src/main/java/bisq/cli/app/CommandParser.java

@@ -2,7 +2,7 @@
 
 import joptsimple.OptionParser;
 
-import static java.lang.System.err;
+import static java.lang.System.out;
 
 final class CommandParser {
 
@@ -21,7 +21,7 @@ OptionParser configure() {
     }
 
     static void printUsage() {
-        err.println("Usage:  bisq-cli getbalance | getversion");
+        out.println("Usage:  bisq-cli getbalance | getversion");
     }
 
 }

core/src/main/java/bisq/core/grpc/BisqGrpcServer.java

@@ -200,7 +200,7 @@ public void stop() {
 
     private void start() throws IOException {
         // TODO add to options
-        int port = 8888;
+        int port = 9998;
 
         // Config services
         server = ServerBuilder.forPort(port)