Skip to content

Commit

Permalink
SBP Trade: Make account name description readable
Browse files Browse the repository at this point in the history
It's hard for the seller to read the buyer's account details because the
string is long, e.g, "Account owner name (first, middle, and initial of
last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank".
I shortened "Account owner name (first, middle, and initial of last
name)" to "Account owner name".
  • Loading branch information
alvasw committed Feb 2, 2025
1 parent c42a8ef commit da73399
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ public static SbpAccountPayload fromProto(protobuf.PaymentAccountPayload proto)
@Override
public String getPaymentDetails() {
return Res.get(paymentMethodId) + " - " +
Res.getWithCol("payment.account.owner.sbp") + " " + holderName + ", " +
Res.getWithCol("payment.account.owner.name") + " " + holderName + ", " +
Res.getWithCol("payment.mobile") + " " + mobileNumber + ", " +
Res.getWithCol("payment.bank.name") + " " + bankName;
}

@Override
public String getPaymentDetailsForTradePopup() {
return Res.getWithCol("payment.account.owner.sbp") + " " + holderName + "\n" +
return Res.getWithCol("payment.account.owner.name") + " " + holderName + "\n" +
Res.getWithCol("payment.mobile") + " " + mobileNumber + "\n" +
Res.getWithCol("payment.bank.name") + " " + bankName;
}
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/i18n/displayStrings.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3720,6 +3720,7 @@ payment.account.name=Account name
payment.account.userName=User name
payment.account.phoneNr=Phone number
payment.account.owner.fullname=Account owner full name
payment.account.owner.name=Account owner name
payment.account.owner.ask=[Ask trader to provide account name if needed]
payment.account.owner.sbp=Account owner name (first, middle, and initial of last name)
payment.account.fullName=Full name (first, middle, last)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class SbpForm extends PaymentMethodForm {
private final SbpValidator SbpValidator;

public static int addFormForBuyer(GridPane gridPane, int gridRow, PaymentAccountPayload paymentAccountPayload) {
addCompactTopLabelTextFieldWithCopyIcon(gridPane, ++gridRow, Res.get("payment.account.owner.sbp"),
addCompactTopLabelTextFieldWithCopyIcon(gridPane, ++gridRow, Res.get("payment.account.owner.name"),
paymentAccountPayload.getHolderName());
addCompactTopLabelTextFieldWithCopyIcon(gridPane, gridRow, 1, Res.get("payment.mobile"),
((SbpAccountPayload) paymentAccountPayload).getMobileNumber());
Expand Down

0 comments on commit da73399

Please sign in to comment.