Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with input validation in create offer view #2044

Closed
devinbileck opened this issue Dec 4, 2018 · 2 comments
Closed

Issue with input validation in create offer view #2044

devinbileck opened this issue Dec 4, 2018 · 2 comments
Assignees
@ripcurlx
Labels
a:bug in:gui

Comments

@devinbileck
Copy link
Member

When creating an offer, after entering amount of BTC to buy I put the cursor in the minimum amount of BTC box and the USD amount box showed error text but not below % box. If I then click in the below % box the values get filled in and the error text remains.
image
@ripcurlx ripcurlx self-assigned this Dec 4, 2018
@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 4, 2018

@devinbileck I'll give it a try. Unfortunately the validation dependencies and logic is quite complex on this screen. Maybe now it is a good time to untangle this parts a little bit.

ripcurlx added a commit to ripcurlx/bisq-desktop that referenced this issue Dec 11, 2018
@ripcurlx
Trigger validation of volume when percentage price is changed. Fixes b…
fe53c0b 
…isq-network#2044.
@ripcurlx ripcurlx mentioned this issue Dec 11, 2018
Merged
@devinbileck devinbileck mentioned this issue Dec 29, 2018
Closed
@cbeams
Copy link
Contributor

cbeams commented Nov 29, 2019

This relates to #3715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
a:bug in:gui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ripcurlx @cbeams @devinbileck