getProperty(AppOptionKeys.APP_DATA_DIR_KEY) is returning default value

[ManfredKarrer]

If you use option --appName=Bisq-1 the result from environment.getProperty(AppOptionKeys.APP_DATA_DIR_KEY);
is Bisq instead of Bisq-1.
If accessed with environment.getAppDataDir(); it is correct.

The default value is applied.

Caused bug at backup (backups Bisq instead of Bisq-1).

[freimair]

That is because --appDataDir is not set and instead, the default is used:

bisq/core/src/main/java/bisq/core/app/BisqExecutable.java

Lines 425 to 428 in 83e1dd3

	parser.accepts(AppOptionKeys.APP_DATA_DIR_KEY,
	"Application data directory")
	.withRequiredArg()
	.defaultsTo(BisqEnvironment.DEFAULT_APP_DATA_DIR);

same cause as #2048 (comment)

I would suggest reverting #1961 as @cbeams suggested in #2063 for the https://github.com/bisq-network/bisq/milestone/21.

However, as the changes of #1961 are much welcome and do clean up the command line API pretty good, I would suggest planning a refactoring of the option processing for a future release.

[ManfredKarrer]

Maybe we can revert only those parts of #1961 where the setting of the defaults have been changed. Seems those are the problematic issues. Would be good to get that asap to get it shipped with the next release mid next week.

[cbeams]

Reverting the removal of the description method and its replacement with JOptSimple’s defaultsTo In commit 83e1dd3 would be enough. Reverting the entire PR would be overkill, as the custom HelpFormatter introduced is effectively separate and not causing any issues.

[ManfredKarrer]

Ah thanks @cbeams - the benefits of granular clean commits ;-)