Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing checks at DAO Bonds confiscation #2123

Closed
ManfredKarrer opened this issue Dec 12, 2018 · 3 comments
Closed

Missing checks at DAO Bonds confiscation #2123

ManfredKarrer opened this issue Dec 12, 2018 · 3 comments
Assignees
@ManfredKarrer @sqrrm
Labels
in:dao

Comments

@ManfredKarrer
Copy link
Contributor

A already confiscated Bond can still be confiscated in the next voting round. The Summary of confiscated bonds also counts up here, so the check to not confiscate an already confiscated bond is probably missing in the domain layer.
@sqrrm
Copy link
Member

sqrrm commented Dec 25, 2018

I have a fix for this, PR coming

sqrrm added a commit to sqrrm/bisq-desktop that referenced this issue Dec 25, 2018
@sqrrm
Fix bisq-network#2123
d17446e
@ManfredKarrer
Copy link
Contributor Author

@sqrrm is that already fixed? If not are you working on that?

@ManfredKarrer ManfredKarrer self-assigned this Jan 30, 2019
@sqrrm
Copy link
Member

sqrrm commented Feb 3, 2019

There is a PR waiting for merge at #2242 which solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManfredKarrer ManfredKarrer

@sqrrm sqrrm

Labels
in:dao
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ripcurlx @ManfredKarrer @sqrrm