Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 4 of trade: Rename "Move funds to Bisq wallet" -> "Keep funds in Bisq wallet" #4255

Closed
cd2357 opened this issue May 12, 2020 · 2 comments

Comments

@cd2357
Copy link
Contributor

cd2357 commented May 12, 2020

Description

The final step of a successful trade offers 2 buttons:

  • Move funds to Bisq wallet
  • Withdraw to external wallet

Judging by their wording, both imply an on-chain transaction. However, only the 2nd one actually causes a transaction, the 1st one simply marks the trade as complete and keeps the funds in the same (Bisq wallet) account.

My suggestion is: rename this button to "Keep funds in Bisq wallet"

That would more accurately describe what it does and avoid confusion for those who want to minimize transactions.

Version

1.3.4

@stale
Copy link

stale bot commented Aug 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 12, 2020
@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant