Rename "Move funds to Bisq wallet" -> "Keep funds in Bisq wallet" to … #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minimize confusion
ghost
suggested changes
May 16, 2020
|
@jmacxx I understand your point, but I think the consistency is good and it helps to better communicate via the code. I also acknowledge it is a small thing, but still, the consistency of the code with the way how its meant for the user helps to communicate the reason why its there. |
|
@petrhejna No need to change the specific language files, only displayStrings.properties needs to be changed. The other ones are handled by the translation team and pulled at release time. I agree with @jmacxx here, better not change the code tag. |
|
Closing in favor of #4313 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just renaming a text according to the proposal from the issue.
Fixies: #4255