Use only first block in pendingBlocks instead of iteration #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfredKarrer
changed the title
|
I will merge that now as I detected a problem in the current master which this PR should avoid. |
|
Sorry for slow review. This looks much better but it still breaks the phase handling. I don't see the big recursions in the log, naturally, so clearly better than before. |
|
Yes I have not looked into the phases yet... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet as more will be added.
@sqrrm Just added that PR for sharing progress on improvements. Needs more testings, but would be good if you could base your testing on that PR.