Minor DAO ui fixes #2109
Merged
Minor DAO ui fixes #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
requested changes
Dec 11, 2018
| @@ -58,7 +58,7 @@ public MenuItem(Navigation navigation, | |||
| this.viewClass = viewClass; | |||
| this.baseNavPath = baseNavPath; | |||
|
|
|||
| setLabelText(title); | |||
| setLabelText(title.toUpperCase()); | |||
There was a problem hiding this comment.
This doesn't handle the 'Vote on proposals'/'Browse open proposals' text that changes depending on phase
There was a problem hiding this comment.
Could be fixed in GovernanceView.java:90/92
There was a problem hiding this comment.
Thanks for pointing it out. Just fixed it by converting to uppercase also on label update.
There was a problem hiding this comment.
And I removed now an unnecessary uppercasing. Should have looked through the code more carefully 🙄
There was a problem hiding this comment.
Yes, better to only set it inside setLabelText as you do now
sqrrm
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.