Focus color of buttons should be more saturated/darker (Issue #2134) #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arker not lighter
CaveSpectre11
requested review from
ManfredKarrer and
ripcurlx
as code owners
|
Hover (right side is hovered):
Focused (right side is focused)
|
|
@ripcurlx Leave it to you. Maybe @pedromvpg could add his opinion as well! |
ripcurlx
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
utACK from a code perspective, but I'd love to get an ACK from @pedromvpg as well, if he's fine with these UI changes.
|
ACK - just tested it locally. @pedromvpg If you want to change the color/saturation, we can adapt it in the next release again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2134 reports an issue with hovering or tabbing focus onto a button lightens the button rather than darkens it, making it more apt to appear disabled.
This PR corrects this behavior by changing the derived color on hover and focused to -30% rather than +30%.
One potential remaining issue is the action that occurs when the button is focused upon tabbing; there is an animated effect that dims the button. While it is now darker than previous, it still becomes somewhat washed out and not as vivid as a mouse hover.