Update offer button state on account change #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add updateButtonDisabledState() to onPaymentAccountSelected() in TakeOfferViewModel since changing the account dropdown in the take offer screen does not trigger an update of the "Next Step" button. The default amount of an offer should not change to less than what is actually offered, change onPaymentAccountSelected() in TakeOfferDataModel to take into account the min. amount offered. In TakeOfferView, the payment account defaults to the last one selected. Make sure TakeOfferViewModel and TakeOfferDataModel take this into account in a couple locations.
|
ACK - @j3ko Thanks for the PR! |
ripcurlx
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2204
Add updateButtonDisabledState() to onPaymentAccountSelected() in
TakeOfferViewModel since changing the account dropdown in the take
offer screen does not trigger an update of the "Next Step" button.
The default amount of an offer should not change to less than what is
actually offered, change onPaymentAccountSelected() in
TakeOfferDataModel to take into account the min. amount offered.
In TakeOfferView, the payment account defaults to the last one
selected. Make sure TakeOfferViewModel and TakeOfferDataModel take
this into account in a couple locations.