Add LOCK_TIME_TRADE_PAYOUT and ARBITRATOR_FEE param #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sqrmm This requires careful testing to guarantee that we are backward compatible.
If a updated client makes a param change request old client do not recognize that enum. To avoid exceptions ro null pointers we fall back to the UNDEFINED enum entry if available. As param value we show an empty string. Beside that issue no problems have been found so far with adding a new param entry.
sqrrm
approved these changes
Jan 30, 2019
|
Will wait with merge after a bit more testing |
ManfredKarrer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sqrrm This requires careful testing to guarantee that we are backward compatible.
@ripcurlx Please leve merge to myself, so we have time to double check to not break anything....