Dao fix issues with majority hash #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
approved these changes
Feb 3, 2019
There was a problem hiding this comment.
utACK
Added some fixes to spelling mistakes and variable naming.
Otherwise this looks better, waiting for the end of batch parsing and checking the current phase at that height before publishing vote. I wonder if our usage of chainHeight, blocHeight, height and what not is lacking since we're getting confused. Perhaps better naming would help us understand better what we're doing.
core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/governance/voteresult/VoteResultException.java
Show resolved
Hide resolved
Co-Authored-By: ManfredKarrer <mk@nucleo.io>
…ealService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
…ealService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
…ealService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
|
Yes we should rename once blockHeight params to be always the same. |
I think we might need to differentiate between parsed height, known last block height, height for a certain block and perhaps even more and use different but consistent names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.