Dao: Add handler for republishing all dao governance data, improve vote result handling #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case that the users blind vote list does not match the hash of the majority we want to find if any variation of our list leads to a match so we can still calculate the vote result.
…sult-with-permutated-blindvotelist
…o-fix-vote-result-with-permutated-blindvotelist # Conflicts: # core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
Remove parsingComplete check
|
@sqrrm I will rebase after i merged master with the other 2 PRs... |
ManfredKarrer
changed the title
ManfredKarrer
changed the title
sqrrm
approved these changes
Feb 3, 2019
| boolean success = p2PService.addPersistableNetworkPayload(proposalPayload, true); | ||
| String txId = proposalPayload.getProposal().getTxId(); | ||
| if (success) { | ||
| log.warn("We received a RepublishGovernanceDataRequest and re-published a proposalPayload to " + |
There was a problem hiding this comment.
Maybe this shouldn't be warning level log
There was a problem hiding this comment.
Yes was also wondering. But it make it more visible if that occurres so that anyone can see if any peer is missing data. Basically the P2P network should be reliable enough to not cause that.
| boolean success = p2PService.addPersistableNetworkPayload(blindVotePayload, true); | ||
| String txId = blindVotePayload.getBlindVote().getTxId(); | ||
| if (success) { | ||
| log.warn("We received a RepublishGovernanceDataRequest and re-published a blindVotePayload to " + |
There was a problem hiding this comment.
Same here, I don't think warning level is right
There was a problem hiding this comment.
Ah, I see now, its at each success case, thats definitely too much. Will fix it in next PR.
ManfredKarrer
deleted the
dao-fix-vote-result-with-permutated-blindvotelist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.