Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update view on activation with block at current chain height #2409

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update view on activation with block at current chain height #2409

merged 1 commit into from
Feb 12, 2019

Conversation

ripcurlx
Copy link
Contributor

Fixes #2408.

@ripcurlx ripcurlx force-pushed the fix-make-proposal-initialization branch from 16a990a to 277084c Compare February 12, 2019 14:02
ManfredKarrer
ManfredKarrer approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the @Nullable/Optional issue utACK

core/src/main/java/bisq/core/dao/DaoFacade.java Outdated
return getBlockAtHeight(getChainHeight());
}

public Block getBlockAtHeight(int chainHeight) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @nullable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or stick with Optional...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already changed everything to Optional. Please see my force pushed state.

ManfredKarrer
ManfredKarrer approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah saw you pushed that already....

@ManfredKarrer ManfredKarrer merged commit fc9119b into bisq-network:master Feb 12, 2019
@ripcurlx ripcurlx mentioned this pull request Feb 26, 2019
Closed
@ripcurlx ripcurlx deleted the fix-make-proposal-initialization branch December 18, 2019 08:32
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

Assignees
No one assigned
Labels
in:dao
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @ManfredKarrer