Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info popup for BEAM accounts. Improve GRIN info popup text. #2423

Merged
merged 2 commits into from
Feb 17, 2019
Merged

Add info popup for BEAM accounts. Improve GRIN info popup text. #2423

merged 2 commits into from
Feb 17, 2019

Conversation

ManfredKarrer
Copy link
Contributor

@ManfredKarrer ManfredKarrer commented Feb 15, 2019 •
edited
Loading

Sorry @ripcurlx I know its code freeze but I think that is a small uncritical PR which would be good to get added.

devinbileck
devinbileck approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit
Just some grammatical issues.

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
ripcurlx
ripcurlx approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ripcurlx
ripcurlx approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 5d15783 into bisq-network:master Feb 17, 2019
@ManfredKarrer ManfredKarrer deleted the add-beam-popup branch February 17, 2019 00:46
@ripcurlx ripcurlx mentioned this pull request Feb 26, 2019
Closed
@devinbileck devinbileck mentioned this pull request Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbileck devinbileck devinbileck approved these changes

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManfredKarrer @ripcurlx @devinbileck