Added feedback popup for DAO test users #2521
Conversation
|
This is great...thanks Ben, glad to have this in the next release. I find the proposed text a little wordy, and also think we should mention the BSQ bounty for doing the feedback survey. The text should be as concise as possible to maximize survey clicks. Here is what I suggest. Thank you for testing the Bisq DAOCan you spare 3 minutes to do a quick survey? We're offering 20 BSQ for completed surveys. Your feedback is crucial to ensuring a smooth launch on mainnet.
Questions, or other issues? Discuss with Bisq users and contributors on the forum:
|
| String testingPopupKey = "daoTestingFeedbackPopup"; | ||
| if (DontShowAgainLookup.showAgain(testingPopupKey)) { | ||
| UserThread.runAfter(() -> { | ||
| if (sortedList.size() > 0 && sortedList.stream().map(proposalsListItem -> proposalsListItem.getProposal().getTxId()) |
There was a problem hiding this comment.
Better to use myProposalListService.getList()' - this gives you your own proposals and test with periodService.isTxInCorrectCycle(tx.getBlockHeight(), daoStateService.getChainHeight())` if it the proposal is in the current cycle.
| @@ -203,6 +209,8 @@ protected void activate() { | |||
|
|
|||
| sortedList.comparatorProperty().bind(tableView.comparatorProperty()); | |||
|
|
|||
| maybeShowDAOTestingFeedbackWindow(); | |||
There was a problem hiding this comment.
Seems that would show the popup after the user has made a proposal. We want to show the popup only after the voting phase in case the user has created a proposal or if he has voted. Sorry that I have not been more clear in the GH issue....
| if (DontShowAgainLookup.showAgain(testingPopupKey)) { | ||
| UserThread.runAfter(() -> { | ||
| if (sortedCycleListItemList.size() > 0 && (sortedCycleListItemList.get(0).getResultsOfCycle().getEvaluatedProposals().stream().map(EvaluatedProposal::getProposalTxId) | ||
| .flatMap(key -> bsqWalletService.getWalletTransactions().stream().map(Transaction::getHashAsString) |
There was a problem hiding this comment.
I would prefer here also to use the DAO domain instead the BTC domain to avoid too much dependency to the wallet.
MyBlindVoteListService holds your own blind votes and with a check for the cycle you see if it is a current vote.
| daoTestingFeedbackWindow.title=Thank you for testing the Bisq DAO | ||
| daoTestingFeedbackWindow.msg.part1=Can you spare 3 minutes to do a quick survey? We're offering 20 BSQ for completed surveys.\ | ||
| \nYour feedback is crucial to ensuring a smooth launch on mainnet. | ||
| daoTestingFeedbackWindow.surveyLinkLabel=Do survey > |
| \nYour feedback is crucial to ensuring a smooth launch on mainnet. | ||
| daoTestingFeedbackWindow.surveyLinkLabel=Do survey > | ||
| daoTestingFeedbackWindow.msg.part2=Questions, or other issues? Discuss with Bisq users and contributors on the forum: | ||
| daoTestingFeedbackWindow.forumLinkLabel=Visit forum > |
|
@ManfredKarrer I fixed according to your comments, hopefully, should be good this time :) |
Fix #2485
I was still unable to properly test the activation of the popup as I'm still setting up my local environment.
This should launch the popup if the user voted or submitted a proposal in the last cycle.