Improve space management in button bar of overlays #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,8 +127,7 @@ protected void onShow() { | |||
| protected void addButtons() { | |||
| super.addButtons(); | |||
|
|
|||
| closeButton.setPrefWidth(162); | |||
| actionButton.setPrefWidth(162); | |||
| closeButton.prefWidthProperty().bind(actionButton.widthProperty()); | |||
There was a problem hiding this comment.
Are you sure the setters are never called in any other popup? It would cause an error if binding is set and we call setWidth somewhere else....
Ah its not in the super class, so should be isolated then to that window.
utACK
There was a problem hiding this comment.
Yes, it was just to have the same button width based on Pedro's design for this popup.
There was a problem hiding this comment.
But still to support bigger button sizes for different languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2681.