Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTF8 for getBytes calls #2737

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Add UTF8 for getBytes calls #2737

merged 1 commit into from
Apr 21, 2019

Conversation

ManfredKarrer
Copy link
Contributor

Fixes #2729

@ManfredKarrer ManfredKarrer requested a review from cbeams as a code owner April 18, 2019 00:56
@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 18, 2019
@ManfredKarrer
Copy link
Contributor Author

@devinbileck Would be great if you could test that on Windows with whole smoke test (trade) as I cahnged all ocurrances of getByte(). I tested on regtest and all worked.

@ManfredKarrer ManfredKarrer requested review from sqrrm and removed request for cbeams April 18, 2019 00:58
ripcurlx
ripcurlx approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Still works for me on macOS and tried it with the changed update message on Windows 10, which works as well.

@devinbileck
Copy link
Member

ACK. Works for me as well on regtest using Windows 10.

devinbileck
devinbileck reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ManfredKarrer
Copy link
Contributor Author

Has anyone tested notifiactions? Not sure if the change there could break something.

@devinbileck
Copy link
Member

Yes, I tested alert notifications as well as private messages (via arbitration). And also used some random UTF-8 characters in the messages. Didn't encounter any issues.

@ManfredKarrer ManfredKarrer merged commit eb1c4fd into bisq-network:master Apr 21, 2019
@ManfredKarrer ManfredKarrer deleted the use-utf8-for-getBytes branch April 21, 2019 22:36
@ripcurlx ripcurlx mentioned this pull request May 3, 2019
Closed
@devinbileck devinbileck mentioned this pull request May 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbileck devinbileck devinbileck left review comments

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
a:bug
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Update prompt not shown on Windows
3 participants
@ManfredKarrer @devinbileck @ripcurlx