Fix dao sync text after restore from seed #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After restoring from seed, the text shown under DAO / BSQ Wallet / Transactions displays an incorrect progress - the numbers are swapped. For example: "Awaiting blocks... Verified 575,868 blocks out of 554,857" Normally we get the latest block height from BitcoinJ as the target height, and we request BSQ blocks from seed nodes up to latest block. But when restoring from seed, we receive the latest block height from the seed nodes while BitcoinJ has not received all blocks yet and is still syncing. Fixes bisq-network#2825
Changes the status text when BTC sync in progress from: Synchronized with Bitcoin Mainnet (using Tor): 10.00% to: Synchronizing with Bitcoin Mainnet (using Tor): 10.00%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After restoring from seed, the text shown under DAO /
BSQ Wallet / Transactions displays an incorrect progress - the numbers
are swapped. For example:
"Awaiting blocks... Verified 575,868 blocks out of 554,857"
Normally we get the latest block height from BitcoinJ as the
target height, and we request BSQ blocks from seed nodes up to latest
block.
But when restoring from seed, we receive the latest block height
from the seed nodes while BitcoinJ has not received all blocks yet and
is still syncing.
Fixes #2825