rename Clock to ClockWatcher #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this class is not a clock but it watches the clock, detects standby and runs periodic tasks. * there is already a jdk method called clock First i thought it should be called PeriodicTaskManager, now i find ClockWatcher more fitting.
|
@sqrmm @ripcurlx can we get this one merged, then i can start injecting clocks to fix unit tests on jdk 11 and 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reasons for the change:
First i thought it should be called PeriodicTaskManager, now i find
ClockWatcher more fitting.