Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase top navigation button text size for Japanese locale #3133

Merged
merged 2 commits into from
Aug 25, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Aug 23, 2019

Before / After screenshots
bisq1
bisq2

@wiz wiz requested review from ripcurlx and sqrrm as code owners August 23, 2019 17:27
@battleofwizards
Copy link
Contributor

Minor suggestion: consider renaming the .nav-button-large to .nav-button-for-japanese-locale.

The class name as it is now suggests some broader use or importance and so is misleading.

Of course, if other languages turn out to need this larger nav, the name may be further changed to be a bit more generic, like .nav-button-for-asian-locales.

Thanks!

Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wiz
Copy link
Contributor Author

wiz commented Aug 24, 2019

@battleofwizards good point, I've changed it to -japanese, leaving it up to other CJK languages to tweak the font-size on their own

@sqrrm sqrrm merged commit 6273246 into bisq-network:master Aug 25, 2019
@wiz wiz deleted the japanese-nav-buttons branch August 28, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants