Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add average bsq price #3212

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Add average bsq price #3212

merged 3 commits into from
Sep 6, 2019

Conversation

chimp1984
Copy link
Contributor

No description provided.

@chimp1984
Copy link
Contributor Author

Screen Shot 2019-09-06 at 04 37 27

@chimp1984 chimp1984 mentioned this pull request Sep 6, 2019
Closed
freimair
freimair suggested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change stuff that actually changes code behavior. It is really cumbersome to check method signatures and whether they changed or not. Your suggestion contains 10+ method headers that have not changed functionally, but all of them are changes. Please revert those unnecessary changes now and in the future. Thanks!

core/src/main/java/bisq/core/offer/OfferUtil.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/offer/OfferUtil.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/offer/OfferUtil.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/util/GUIUtil.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/util/GUIUtil.java Outdated Show resolved Hide resolved
@chimp1984
Copy link
Contributor Author

@freimair I try to clean up classes I touch. As siad above appying the formatting rules should be mandatory anyway to all commits IMO.

@freimair
Copy link
Contributor

freimair commented Sep 6, 2019

yes, applying formatting rules IS mandatory but only for new or functionally changed code. In the end, everything should be the same, however, it takes a lot more time reviewing changes that are no changes. So you might encounter longer times until stuff gets merged.

freimair
freimair approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

aand we shall not forget to get these changes into master...

@freimair freimair mentioned this pull request Sep 6, 2019
Closed
@ripcurlx
Copy link
Contributor

ripcurlx commented Sep 6, 2019

Ack

aand we shall not forget to get these changes into master...

After the release I'll rebase and merge this branch into master anyways.

@ripcurlx ripcurlx merged commit 7c034a4 into bisq-network:release/v1.1.6 Sep 6, 2019
@chimp1984 chimp1984 deleted the add-average-bsq-price branch September 6, 2019 19:59
@chimp1984 chimp1984 mentioned this pull request Sep 6, 2019
Closed
@ripcurlx ripcurlx mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx left review comments

@freimair freimair freimair approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @freimair @ripcurlx