Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and rename Portfolio History columns meaningfully #3345

Closed
wants to merge 3 commits into from
Closed

Add and rename Portfolio History columns meaningfully #3345

wants to merge 3 commits into from

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Sep 28, 2019 •
edited
Loading

Fixes #3338

freimair
freimair suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this contribution in our Bisq. However,

  • please check the formatting
  • please do not commit import-rearrangements

@niyid
Copy link
Contributor Author

niyid commented Nov 11, 2019 •
edited
Loading

I would love to see this contribution in our Bisq. However,

  • please check the formatting
  • please do not commit import-rearrangements

@freimair
Sorry about that. I have reverted to preexisting import arrangement and formatting.

Fixes #3338

@niyid niyid requested a review from freimair November 11, 2019 14:05
@ripcurlx
Copy link
Contributor

@niyid Please sign all your commits.

@stale
Copy link

stale bot commented Dec 12, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added was:dropped and removed was:dropped labels Dec 12, 2019
@niyid niyid mentioned this pull request Dec 12, 2019
Closed
@niyid
Copy link
Contributor Author

niyid commented Dec 13, 2019

Recreated as #3785

@niyid niyid closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

@sqrrm sqrrm Awaiting requested review from sqrrm

@freimair freimair Awaiting requested review from freimair

Assignees
No one assigned
Labels
waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and rename Portfolio History columns meaningfully
3 participants
@niyid @ripcurlx @freimair