-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account validation #3575
Account validation #3575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - Please see my comments
desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java
Outdated
Show resolved
Hide resolved
@beingindot Also all your commits need signing and you need to resolve the conflict now that your other PR got merged. |
c74c08c
to
4432d80
Compare
@ripcurlx Resolved conflicts and included changes. pls check. |
#3460
Added empty check validation for
popmoney/uphold/revolut/zelle
bank forms already have required changes with previous PR.