Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolut account should accept only phone number #3777

Merged

Conversation

beingindot
Copy link
Contributor

Fixes #3728
Till now we used to accept email or phone number
Now we are accepting only phone number in input though
for display we will provide backward compatibility.

Based on the country selected, we will validate the given phone number input.

Added list of countries accepted from official revolut website
https://www.revolut.com/en-US/help/getting-started/verifying-identity/what-countries-are-supported

@beingindot beingindot force-pushed the revolut-phonenumber-validation branch from 6a888a5 to 0ee88af Compare December 12, 2019 11:45
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 12, 2019
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

I tested it on Regtest and when switching the country in the combobox the validation is not updated. See screenshots below.

Bildschirmfoto 2019-12-12 um 15 42 54
When I switch the country to German the validation condition should be fulfilled, but is still showing the Austrian country code error message
Bildschirmfoto 2019-12-12 um 15 43 05

@beingindot beingindot force-pushed the revolut-phonenumber-validation branch from 0ee88af to e9e1620 Compare December 13, 2019 08:38
@beingindot
Copy link
Contributor Author

beingindot commented Dec 13, 2019

Now I have added updateAllInputsValid() from combobox action event. that triggers validation and it enables save new account.

but the error message around text field is not clearing on its own. only after we press tab it clears. I tried to use accountIdInputTextField.resetValidation() but not working so far. may be that's an existing bug? pls provide suggestions.

@ripcurlx
Copy link
Contributor

resetValidation

It has to be used similar as in the Bankform

holderNameInputTextField.resetValidation();
holderNameInputTextField.validate();

For issue bisq-network#3728
	Till now we used to accept email or phone number
	Now we are accepting only phone number in input though
	for display we will provide backward compatibility.

	Added list of countries accepted from official revolut website
	https://www.revolut.com/en-US/help/getting-started/verifying-identity/what-countries-are-supported

	Based on the country selected, we will validate the given
	phone number input.
@beingindot beingindot force-pushed the revolut-phonenumber-validation branch from e9e1620 to da683e8 Compare December 17, 2019 15:33
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested it on Regtest and it is working now as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revolut account should be a phone number
2 participants