Prevent memory leak in CandleStickChart & VolumeChart #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the superclass methods XYChart.removeDataItemFromDisplay & XYChart.removeSeriesFromDisplay are always called from the implemented dataItemRemoved & seriesRemoved methods respectively, as specified by the API javadoc. This prevents a leak of old Candle & VolumeBar objects every time the trades charts view is updated. The former is quite substantial, as each Candle object has a retained size of about 70kB and there are up to 90 candlesticks / volume bars leaked per chart update.
stejbac
force-pushed
the
fix-trades-charts-memory-leak
branch
from
ab2ad33 to
7b7ea64
Compare
ripcurlx
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
ACK
Tested PR against Mainnet switching between time frames and currencies and everything seems to be still working as before from a user perspective. Code changes looking fine to me as well, but I didn't verified the change using jProfiler. If anyone wants to review/verify this part as well feel free to do so.
ripcurlx
added
a:bug
is:priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the superclass methods
XYChart.removeDataItemFromDisplayandXYChart.removeSeriesFromDisplayare always called from the implementeddataItemRemovedandseriesRemovedmethods respectively, as specified by the API javadoc.This prevents a leak of old
CandleandVolumeBarobjects every time the trades charts view is updated. The former is quite substantial, as each Candle object has a retained size of about 70kB and there are up to 90 candlesticks / volume bars leaked per chart update.--
By cycling through the Month, Week and Day interval a few dozen times, the following heap usage stats were obtained using JProfiler:
I believe updates to the two charts happen periodically as long as the trades charts view is selected, as it appeared to leak while unattended as well. I haven't had a chance to measure the rate, though.