Suppress netty.shaded debug stack traces in cli #4091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghubstan Could you please resolve the conflict caused by a recent merge. Thanks! |
ripcurlx
added
waiting for author
is:priority
ghubstan
force-pushed
the
configure-cli-logging
branch
2 times, most recently
from
6c8ae6d to
f1939d0
Compare
Configure cli loggers to avoid scary but ignorable netty debug log messages with stack traces: "Reflective setAccessible(true)", and those showing unsuccessful netty native lib load attempts. It may be preferable to not use logback in cli, and achieve the same result programmatically with slf4j, but this shows how to hide this ugly log output in the meantime. Remove comment about why these messages were logged, and switch to non-deprecated ManagedChannelBuilder.forAddress(host, port) .usePlaintext().build() in BisqCliMain.
ghubstan
force-pushed
the
configure-cli-logging
branch
from
f1939d0 to
6bd7f22
Compare
|
@ripcurlx , merge conflict resolved |
|
Closing because merged PR #4097 has this change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure cli loggers to avoid scary but ignorable netty debug
log messages with stack traces: "Reflective setAccessible(true)",
and those showing unsuccessful netty native lib load attempts.
It may be preferable to not use logback in cli, and achieve the
same result programmatically with slf4j, but this shows how to
hide this ugly log output in the meantime.
Remove comment about why these messages were logged, and switch
to non-deprecated ManagedChannelBuilder.forAddress(host, port)
.usePlaintext().build()
in BisqCliMain.