Pricenode: Remove unused maxBlocks param #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd2357
changed the title
cd2357
force-pushed
the
remove-unused-maxBlocks-param-retry
branch
from
521b7c4 to
2ff152c
Compare
|
@wiz Can you coordinate this? Should I just merge this or wait until you're ready for it? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@cd2357 Could you please resolve the conflict with master so we are able to merge it? Thanks! |
As the new fee estimation API does not require this parameter anymore, remove it and all references to it. See bisq-network/projects#27
cd2357
force-pushed
the
remove-unused-maxBlocks-param-retry
branch
from
2ff152c to
33550ca
Compare
|
@ripcurlx done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new fee estimation API does not require this parameter anymore, remove it and all references to it.
As @cbeams mentioned in #4235 (review): merging this change should be coordinated with the pricenode operators.
What this changes for running a pricenode: starting the pricenode now takes one argument instead of two, so make sure to update any startup scripts and remove the first argument (which used to represent
maxBlocks).See bisq-network/projects#27