-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header and other visual tweaks #4398
Conversation
0aeb8d2
to
5a16db8
Compare
Just tried to re-trigger the build as I had the line length configured wrong. 80 instead of 90 chars |
Any action needed on my end? |
You could try a force push to re-trigger the codacy checks, otherwise I'll do it on Tuesday. |
@pedromvpg As I'm not able to push to your repo (because of git lfs issues
|
48f1c90
to
b1d4a41
Compare
Done
And done
|
🤣 Now Travis had issues during the build. I just re-triggered the JDK 12 test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
@pedromvpg Your last commit wasn't signed. |
b1d4a41
to
636e20f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
@pedromvpg @ripcurlx I guess you guys only tested this on English because it totally breaks the Japanese top GUI layout. I made a PR #4448 to revert it for now. Pedro, let's work together testing your next PR with all languages :) |
Reduce header visual elements and prevent it from over growing when client widow goes wider.
More minimal and flatter look to keep it current with the times! 💸