Remove redundant ApiTestConfig options #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing String[] params to the method signature, so test cases can pass any needed combination of options to the scaffolding setup from a @BeforeAll method.
* The bats test script was moved to the apitest subproject and renamed. * Version tests were updated for release 1.3.7. * The duplicated "test getoffers buy eur check return status" was replaced by a new "test getoffers sell eur check return status" test. * The bats dependency was switched to bats-core because development has halted on https://github.com/sstephenson/bats/tree/master. The new bats repository is https://github.com/bats-core/bats-core/tree/master
The :apitest GrpcStubs class was removed and recreated in the :cli subproject, to be used by both :cli and :apitest. CliMain was changed to use the new GrpcStubs.
This change removes three options: runArbNodeAsDesktop, runAliceNodeAsDesktop, and runBobNodeAsDesktop, which should have been deleted when the supportingApps option was added. The comma delimited list of apps passed with the supportingApps option now determines whether arbitration / bob / alice nodes are started as desktops or daemons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes three
:apitestscaffold setup options:runArbNodeAsDesktop,runAliceNodeAsDesktop, andrunBobNodeAsDesktop, which should have been deleted when thesupportingAppsoption was added. The comma delimited list of apps passed with thesupportingAppsoption now determines whetherarbitration/bob/alicenodes are started as desktops or daemons.PR 4 of 5, to be reviewed/merged in PR number order.